-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REM-1303: Fetch particular state by address #38
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
===========================================
+ Coverage 97.35% 97.41% +0.06%
===========================================
Files 30 35 +5
Lines 568 620 +52
===========================================
+ Hits 553 604 +51
- Misses 15 16 +1
Continue to review full report at Codecov.
|
Just decide we write Think, |
Remove from PR description |
README.md
Outdated
|
||
```bash | ||
$ remme state get \ | ||
--address=0000000000000000000000000000000000000000000000000000000000000000000001 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you use this address? Is this an account address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anastasiia-bilova, yes it is, but I change it's to another address.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use your real account address. In tests too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anastasiia-bilova, what will it change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This address 0000000000000000000000000000000000000000000000000000000000000000000001
doesn't say anything. You must show which address you use, address account
or node_account
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but what a difference between returned data account type address
and node account
?
In README I have changed the address for more clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no difference, just for the perception that you are using a real address.
Make commit messages more understandable. Look at this article. |
Jira references
Description
Get state by its address command line interface's command implementation.
Example of the usage:
References