Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REM-1303: Fetch particular state by address #38

Merged
merged 6 commits into from
May 8, 2019
Merged

Conversation

Alladin9393
Copy link
Contributor

@Alladin9393 Alladin9393 commented May 6, 2019

Jira references

Description

Get state by its address command line interface's command implementation.

Example of the usage:

Arguments Type Required Description
address String Yes Account address to get a state by.
node-url String No Node URL to apply a command to.
$ remme state get \
      --address=000000a87cb5eafdcca6a8cde0fb0dec1400c5ab274474a6aa82c12840f169a04216b7 \
      --node-url=node-6-testnet.remme.io
{
    "result": {
        "state": {
            "data": "CmwKJnNhd3Rvb3RoLnNldHRpbmdzLnZvdGUuYXV0aG9yaXplZF9rZXlzEkIwMmE2NTc5NmYyNDkwOTFjMzA4NzYxNGI0ZDljMjkyYjAwYjhlYmE1ODBkMDQ1YWMyZmQ3ODEyMjRiODdiNmYxM2U=",
            "head": "95d78133eb98628d5ff17c7d1972b9ab03e50fceeb8e199d98cb52078550f5473bb001e57c116238697bdc1958eaf6d5f096f7b66974e1ea46b9c9da694be9d9"
        }
    }
}

References

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #38 into develop will increase coverage by 0.06%.
The diff coverage is 98.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    97.35%   97.41%   +0.06%     
===========================================
  Files           30       35       +5     
  Lines          568      620      +52     
===========================================
+ Hits           553      604      +51     
- Misses          15       16       +1
Impacted Files Coverage Δ
cli/entrypoint.py 100% <100%> (ø) ⬆️
cli/state/cli.py 100% <100%> (ø)
cli/state/forms.py 100% <100%> (ø)
cli/state/service.py 100% <100%> (ø)
cli/state/help.py 100% <100%> (ø)
cli/state/interfaces.py 66.66% <66.66%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d11f13...c3a3f46. Read the comment docs.

README.md Outdated Show resolved Hide resolved
cli/state/forms.py Outdated Show resolved Hide resolved
cli/state/service.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Outdated Show resolved Hide resolved
@dmytrostriletskyi
Copy link
Contributor

dmytrostriletskyi commented May 6, 2019

Just decide we write fetch a particular state by address or fetch a state by address, or get state by its address, etc. and write it in all cases. There are a lot of points with different writing.

Think, get state by address is a perfect variant.

@anastasiia-bilova
Copy link
Contributor

Remove from PR description Get a particular state by its address — remme state get: and add Example of the usage:.

README.md Show resolved Hide resolved
README.md Outdated

```bash
$ remme state get \
--address=0000000000000000000000000000000000000000000000000000000000000000000001 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you use this address? Is this an account address?

Copy link
Contributor Author

@Alladin9393 Alladin9393 May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasiia-bilova, yes it is, but I change it's to another address.
Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use your real account address. In tests too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasiia-bilova, what will it change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This address 0000000000000000000000000000000000000000000000000000000000000000000001 doesn't say anything. You must show which address you use, address account or node_account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but what a difference between returned data account type address and node account?
In README I have changed the address for more clarity.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no difference, just for the perception that you are using a real address.

cli/state/cli.py Outdated Show resolved Hide resolved
cli/state/help.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Outdated Show resolved Hide resolved
tests/state/test_get_state.py Show resolved Hide resolved
@anastasiia-bilova
Copy link
Contributor

Make commit messages more understandable. Look at this article.

tests/state/test_get_state.py Outdated Show resolved Hide resolved
@Remmeauth Remmeauth deleted a comment from anastasiia-bilova May 8, 2019
@Remmeauth Remmeauth deleted a comment from anastasiia-bilova May 8, 2019
@Remmeauth Remmeauth deleted a comment from anastasiia-bilova May 8, 2019
@Alladin9393 Alladin9393 merged commit bb56429 into develop May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the get-state branch May 8, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants