Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate sort requirements and imports, pytest inits linters #32

Merged
merged 4 commits into from
May 2, 2019
Merged

Integrate sort requirements and imports, pytest inits linters #32

merged 4 commits into from
May 2, 2019

Conversation

dmytrostriletskyi
Copy link
Contributor

@dmytrostriletskyi dmytrostriletskyi commented Apr 27, 2019 •
edited
Loading

I have integrated linters.io. It allows us:

  1. Sort requirements in alphabetical order.
  2. Remove __init__.py files in the tests folder.
  3. Remove script to run isort with failed exit code.

References

@dmytrostriletskyi dmytrostriletskyi mentioned this pull request May 2, 2019
Open
34 tasks
@codecov-io
Copy link

codecov-io commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #32 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #32   +/-   ##
========================================
  Coverage    96.56%   96.56%           
========================================
  Files           24       24           
  Lines          379      379           
========================================
  Hits           366      366           
  Misses          13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c768f...758ef2f. Read the comment docs.

@dmytrostriletskyi dmytrostriletskyi merged commit b2371d8 into develop May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the improve-lintering branch May 2, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alladin9393 Alladin9393 Alladin9393 approved these changes

@anastasiia-bilova anastasiia-bilova anastasiia-bilova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytrostriletskyi @codecov-io @Alladin9393 @anastasiia-bilova