Implement getting node configurations #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrostriletskyi
force-pushed
the
get-node-configs
branch
from
add326a
to
ee6bfa6
Compare
Codecov Report
@@ Coverage Diff @@
## develop #25 +/- ##
===========================================
+ Coverage 95.71% 96.09% +0.37%
===========================================
Files 15 19 +4
Lines 210 256 +46
===========================================
+ Hits 201 246 +45
- Misses 9 10 +1
Continue to review full report at Codecov.
|
Annitra
approved these changes
Apr 23, 2019
… into get-node-configs
anastasiia-bilova
suggested changes
Apr 24, 2019
README.md
Outdated
| @@ -139,6 +140,26 @@ $ remme account transfer-tokens \ | |||
| } | |||
| ``` | |||
|
|
|||
| ### Node | |||
|
|
|||
| Get node configurations — ``remme node get-configurations``: | |||
There was a problem hiding this comment.
Suggested change
| Get node configurations — ``remme node get-configurations``: | |
| Get node configurations — ``remme node get-configs``: |
There was a problem hiding this comment.
@anastasiia-bilova, done.
README.md
Outdated
|
|
||
| | Arguments | Type | Required | Description | | ||
| | :-------: | :----: | :-------: | ------------------------------------ | | ||
| | node-url | String | No | Node URL to apply a command to. | |
There was a problem hiding this comment.
Suggested change
| | node-url | String | No | Node URL to apply a command to. | | |
| | node-url | String | No | Node URL to apply a command to. | |
There was a problem hiding this comment.
@anastasiia-bilova, done.
cli/node/service.py
Outdated
| @implements(NodeInterface) | ||
| class Node: | ||
| """ | ||
| Implements account. |
There was a problem hiding this comment.
Suggested change
| Implements account. | |
| Implements node. |
There was a problem hiding this comment.
@anastasiia-bilova, done.
anastasiia-bilova
approved these changes
Apr 24, 2019
Art17
approved these changes
Apr 25, 2019
anastasiia-bilova
force-pushed
the
get-node-configs
branch
from
78f80ab
to
585af77
Compare
anastasiia-bilova
force-pushed
the
get-node-configs
branch
from
585af77
to
0ed94c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira references
Description
Getting node configurations command line interface's command implementation.
Example of the usage:
$ remme node get-configs --node-url=node-genesis-testnet.remme.io { "node_address": "1168296ecf036e857f42129b58303bcf1e03723764a1702cbe98529802aad8514ee3cf", "node_public_key": "03738df3f4ac3621ba8e89413d3ff4ad036c3a0a4dbb164b695885aab6aab614ad" }References
Remme-core— https://github.com/Remmeauth/remme-client-python