REM-1366: Integrate configuration file reading to the commands #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegrate-config-file-reading-to-commands
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
- Coverage 95.45% 95.03% -0.43%
===========================================
Files 10 10
Lines 154 161 +7
===========================================
+ Hits 147 153 +6
- Misses 7 8 +1
Continue to review full report at Codecov.
|
…tegrate-config-file-reading-to-commands
anastasiia-bilova
force-pushed
the
integrate-config-file-reading-to-commands
branch
from
f51d2b5
to
6d5bed5
Compare
Annitra
approved these changes
Apr 24, 2019
…tegrate-config-file-reading-to-commands
…tegrate-config-file-reading-to-commands
anastasiia-bilova
force-pushed
the
integrate-config-file-reading-to-commands
branch
from
6d5bed5
to
542c4f0
Compare
dmytrostriletskyi
approved these changes
Apr 24, 2019
| @@ -44,8 +44,12 @@ def read(self, name): | |||
|
|
|||
| Return dictionary. | |||
| """ | |||
| with open(self.path + '/.' + name + '.yml') as config_file: | |||
| return yaml.safe_load(config_file) | |||
| try: | |||
There was a problem hiding this comment.
Return dictionary > Return dictionary if configurations are presented, else None.
There was a problem hiding this comment.
@dmytrostriletskyi, done.
…tegrate-config-file-reading-to-commands
anastasiia-bilova
force-pushed
the
integrate-config-file-reading-to-commands
branch
from
eae70f2
to
a33e93d
Compare
delete-merged-branch
bot
deleted the
integrate-config-file-reading-to-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira references
Description
Using the command line interface, you will have an option to declare the
node URLto send commands to as illustrated below:$ remme account get-balance \ --address=1120076ecf036e857f42129b58303bcf1e03723764a1702cbe98529802aad8514ee3cf \ --node-url=node-genesis-testnet.remme.ioYou shouldn't declare
node URLevery time when you execute a command, use configuration file instead. Configuration file is required to be named.remme-core-cli.ymland located in the home directory (~/).The configuration file have an optional section to declare
node URLto send commands to:Try it out by downloading the example of the configuration file to the home directory.
The
node URLwill be read every time from the configuration file (.remme-core-cli.yml) unless you provide it in the command line interface:$ remme account get-balance \ --address=1120076ecf036e857f42129b58303bcf1e03723764a1702cbe98529802aad8514ee3cfIf you do not provide the
node URLneither in the command line interface nor in the configuration file,node URLwill be equal tolocalhostby default.