Get Atomic Swap public key #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #20 +/- ##
===========================================
+ Coverage 96.41% 96.56% +0.15%
===========================================
Files 20 24 +4
Lines 335 379 +44
===========================================
+ Hits 323 366 +43
- Misses 12 13 +1
Continue to review full report at Codecov.
|
anastasiia-bilova
force-pushed
the
get-swap-public-key
branch
from
13eab98
to
7930287
Compare
Annitra
approved these changes
Apr 25, 2019
…t-swap-public-key
Art17
approved these changes
Apr 26, 2019
dmytrostriletskyi
approved these changes
Apr 26, 2019
cli/atomic_swap/forms.py
Outdated
| from cli.generic.forms.fields import NodeURLField | ||
|
|
||
|
|
||
| class GetPublicKeyForm(Schema): |
There was a problem hiding this comment.
GetPublicKeyForm > GetAtomicSwapPublicKeyForm.
There was a problem hiding this comment.
@dmytrostriletskyi, done.
cli/constants.py
Outdated
| @@ -17,6 +17,7 @@ | |||
| CLI_CONFIG_FILE_NAME = 'remme-core-cli' | |||
|
|
|||
| NODE_IP_ADDRESS_FOR_TESTING = '159.89.104.9' | |||
|
|
|||
There was a problem hiding this comment.
Remove this changes.
There was a problem hiding this comment.
@dmytrostriletskyi, done.
Art17
approved these changes
Apr 26, 2019
…t-swap-public-key
…t-swap-public-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira references
Description
Get the public key of the Atomic Swap command line interface's command implementation.
Example of the usage:
$ remme atomic-swap get-public-key --node-url=node-6-testnet.remme.io { "result": { "public_key": "03738df3f4ac3621ba8e89413d3ff4ad036c3a0a4dbb164b695885aab6aab614ad" } }Implemented
— Command line interface's command.
— Service to get the public key of the atomic swap class.
References