Get information about public key by public key address #17

anastasiia-bilova · 2019-04-16T19:38:40Z

Jira references

Ticket (task) — https://remmeio.atlassian.net/browse/REM-1311

Description

Get information about public key by its address command line interface's command implementation.

Arguments	Type	Required	Description
address	String	Yes	Public key address to get information about public key by.
node-url	String	No	Node URL to apply a command to.

Example of the usage:

$ remme public-key get-info \
      --address=a23be17addad8eeb5177a395ea47eb54b4a646f8c570f4a2ecc0b1d2f6241c6845181b \
      --node-url=node-genesis-testnet.remme.io
{
    "result": {
        "information": {
            "address": "a23be10d215132aee9377cfe26b6d301d32da070a799c227fb4701103e5626d48cd6ba",
            "entity_hash": "1edd6d5b1c722a83e03b17180b888d89ec4c079a0044f074b7c8bb2720cad8ba4e97a80c7edbd24c1824f5312dfd8a0877453394a63410b52c1f16e1d60ef754",
            "entity_hash_signature": "1322ca51fb6d33e44d2b6c028eb668b5712a5277bbdea089112203e8e950d1c7d02d446291865a2f5fca4c6767fb84583e53205df850f1fc05ea6f22c736635f425b0159881f7f998da52378bf08353d87d2a2c226a7ababea9a245e69be06d54c573a42c3be907ca49589a67b5e9cc4d8ed12cea8546b2df531fd9620f4dc71869d8fa0bfcbef239d9a6e2e3bf12bcac4fd562b22ff408d7b077b75d8e59af0348264a7c9e7e61b4c5f844636a0fbbcfae61955efdf10323a992ea2a1734eb0ee7952519b00e696a02e7460771b0e0887e011b709e88abfda896b68150c08dcf6b4bf7c70f996f6031c13311056ab935ce1fdf63d3f19b5a3ca6ae604c4f12b",
            "is_revoked": false,
            "is_valid": true,
            "owner_public_key": "03738df3f4ac3621ba8e89413d3ff4ad036c3a0a4dbb164b695885aab6aab614ad",
            "public_key": "30820122300d06092a864886f70d01010105000382010f003082010a02820101008b29cc5ec32dab21b48b63faf2fd00f88879b9d4286c3cde6218d19263ea8226fce499039968c5f9736149e298bbc56680b516f2d83507d88fb95771445ca3c59bcdbb31bb5993a4e5dfcd2c4bc86328ec76e95e2f4582f9cac8223a2f16a2b14c4358b6fb105e37baf9daa9bd5b708ab204d8015a1ce782e28024eae1801151616c90a3b1aa1916d5b8dd021b3aa4cec77450660841f8619a7234c6199d01ccd43b1d6ff7fa5f50bf80bc06b682b126bdca0753a6830b7a95afca79442ec64fd09ddcc34627dcbdad0c5e66317db98d0e1c24c3f992b83f4b0f97e2b0300a2cb51e33eccf060f26b4e19a88f15216f8c17be5f5e023a1f260f7c93a2a4523ed0203010001",
            "type": "rsa",
            "valid_from": 1556118334,
            "valid_to": 1587222334
        }
    }
}

Implemented

— Command line interface's command.
— Service to get information about the public key of the public key class.

References

CLI framework — https://click.palletsprojects.com/en/7.x
Library to interact with Remme-core — https://github.com/Remmeauth/remme-client-python
Custom Marshmellow fields — https://marshmallow.readthedocs.io/en/3.0/custom_fields.html

…i into get-public-key-info-by-account-address

codecov-io · 2019-04-16T19:41:32Z

Codecov Report

Merging #17 into develop will increase coverage by 0.1%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##           develop      #17     +/-   ##
==========================================
+ Coverage     96.3%   96.41%   +0.1%     
==========================================
  Files           20       20             
  Lines          298      335     +37     
==========================================
+ Hits           287      323     +36     
- Misses          11       12      +1

Impacted Files	Coverage Δ
cli/generic/forms/fields.py	`100% <100%> (ø)`	⬆️
cli/public_key/cli.py	`100% <100%> (ø)`	⬆️
cli/public_key/help.py	`100% <100%> (ø)`	⬆️
cli/public_key/forms.py	`100% <100%> (ø)`	⬆️
cli/constants.py	`100% <100%> (ø)`	⬆️
cli/public_key/service.py	`100% <100%> (ø)`	⬆️
cli/public_key/interfaces.py	`60% <50%> (-6.67%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3ba52...a9bbdcb. Read the comment docs.

…t-public-key-info-by-account-address

…and refactoring tests

…t-public-key-info-by-account-address

dmytrostriletskyi · 2019-04-26T12:14:58Z

README.md

@@ -184,6 +184,35 @@ $ remme public-key get-list \
 }
 ```

+Get information about public key address by public key address — ``remme public-key get-info``:


Get information about public key address... > Get information about public key....

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:16:12Z

cli/public_key/cli.py

+@public_key_commands.command('get-info')
+def get_public_key_info(address, node_url):
+    """
+    Get information about public key address by public key address.


The same about you get information about the public key, not its address.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:17:32Z

cli/public_key/forms.py

 )


+class GetPublicKeyInfoForm(Schema):
+    """
+    Get information about public key address of the public key info form.


The same about the address.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:17:45Z

cli/public_key/forms.py

 )


+class GetPublicKeyInfoForm(Schema):


GetPublicKeyInfoForm > GetPublicKeyInformationForm.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:18:11Z

cli/public_key/interfaces.py

@@ -8,6 +8,12 @@ class PublicKeyInterface:
    Implements public key interface.
    """

+    def get(self, address):
+        """
+        Get information about public key address by public key address.


The same about the address.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:21:10Z

tests/conftest.py

@@ -91,6 +91,43 @@ def batch_id(self):
               '08f5308af03fd4aa18ff1d868f043b12dd7b0a792e141f000a2505acd4b7a956'


+class PublicKeyInfo:


PublicKeyInfo > PublicKeyInformation.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T12:22:05Z

tests/public_key/test_get_public_key_info.py

+    public_key_info = json.loads(result.output).get('result').get('public_key_info')
+
+    assert PASSED_EXIT_FROM_COMMAND_CODE == result.exit_code
+


Remove this blank line.

@dmytrostriletskyi, I wanted to separate the different asserts, removed blank line.

dmytrostriletskyi · 2019-04-26T12:22:30Z

tests/public_key/test_get_public_key_info.py

+
+def test_get_public_key_info_invalid_address():
+    """
+    Case: get information about public key address by invalid address.


The same with the address. Fix in other tests.

@dmytrostriletskyi, done.

…t-public-key-info-by-account-address

dmytrostriletskyi · 2019-04-26T14:26:00Z

README.md

            "a23be10b3aad1b4a98f338c71d6dcdb2aa2f296c7e31fb400615e335dc10dd1d4f62bf",
            "a23be14b362514d624c1985277005327f6fc40413fb090eee6fccb673a32c9809060ff"
        ]
    }
 }
 ```

+Get information about public key by public key address — ``remme public-key get-info``:


Consider to change it to Get information about public key by its address. A bit easier to read.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-26T14:27:11Z

tests/conftest.py

+    @property
+    def data(self):
+        """
+        Get data of public key information.


Why not just Get public key information?

@dmytrostriletskyi, done.

dmytrostriletskyi and others added 3 commits April 16, 2019 17:28

Create dictionary to pretty json util

756d8f1

Create command line interface for function get public key

e109f8e

Merge branch 'pretty-json-util' of github.com:Remmeauth/remme-core-cl…

35b6673

…i into get-public-key-info-by-account-address

anastasiia-bilova requested a review from dmytrostriletskyi April 16, 2019 19:38

anastasiia-bilova added 3 commits April 18, 2019 09:55

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

cd88e9f

…t-public-key-info-by-account-address

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

635055e

…t-public-key-info-by-account-address

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

232f99a

…t-public-key-info-by-account-address

anastasiia-bilova force-pushed the get-public-key-info-by-account-address branch from cba6712 to d726647 Compare April 25, 2019 10:16

Add error processing, form vaclidaton for public key address, create …

4b96a28

…and refactoring tests

anastasiia-bilova force-pushed the get-public-key-info-by-account-address branch from d726647 to 799a16b Compare April 25, 2019 14:34

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

db74e1f

…t-public-key-info-by-account-address

anastasiia-bilova force-pushed the get-public-key-info-by-account-address branch from 799a16b to db74e1f Compare April 25, 2019 16:06

anastasiia-bilova requested a review from Annitra April 25, 2019 16:07

Annitra approved these changes Apr 25, 2019

View reviewed changes

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

630f524

…t-public-key-info-by-account-address

anastasiia-bilova requested a review from Alladin9393 April 26, 2019 11:49

dmytrostriletskyi suggested changes Apr 26, 2019

View reviewed changes

Remmeauth deleted a comment from dmytrostriletskyi Apr 26, 2019

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

d8770d5

…t-public-key-info-by-account-address

Remmeauth deleted a comment from dmytrostriletskyi Apr 26, 2019

anastasiia-bilova requested review from Art17 and removed request for Alladin9393 April 26, 2019 14:20

dmytrostriletskyi approved these changes Apr 26, 2019

View reviewed changes

anastasiia-bilova force-pushed the get-public-key-info-by-account-address branch from 177686f to 8f357d8 Compare April 26, 2019 14:33

Apply review comments: refactor documentation

a9bbdcb

anastasiia-bilova force-pushed the get-public-key-info-by-account-address branch from 8f357d8 to a9bbdcb Compare April 26, 2019 14:34

Art17 approved these changes Apr 26, 2019

View reviewed changes

anastasiia-bilova merged commit 079d447 into develop May 2, 2019

delete-merged-branch bot deleted the get-public-key-info-by-account-address branch May 2, 2019 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get information about public key by public key address #17

Get information about public key by public key address #17

anastasiia-bilova commented Apr 16, 2019 •

edited

Loading

codecov-io commented Apr 16, 2019 •

edited

Loading

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

dmytrostriletskyi Apr 26, 2019

anastasiia-bilova Apr 26, 2019

		@@ -91,6 +91,43 @@ def batch_id(self):
		'08f5308af03fd4aa18ff1d868f043b12dd7b0a792e141f000a2505acd4b7a956'


		class PublicKeyInfo:

		public_key_info = json.loads(result.output).get('result').get('public_key_info')

		assert PASSED_EXIT_FROM_COMMAND_CODE == result.exit_code

Get information about public key by public key address #17

Get information about public key by public key address #17

Conversation

anastasiia-bilova commented Apr 16, 2019 • edited Loading

Jira references

Description

Implemented

References

codecov-io commented Apr 16, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anastasiia-bilova commented Apr 16, 2019 •

edited

Loading

codecov-io commented Apr 16, 2019 •

edited

Loading