Get list of the public keys by account address on which these keys depend #16

anastasiia-bilova · 2019-04-16T16:27:53Z

Jira references

Ticket (task) — https://remmeio.atlassian.net/browse/REM-1310

Description

Get a list of the addresses of the public keys by its account address command line interface's command implementation.

Arguments	Type	Required	Description
address	String	Yes	Account address to get a list of the addresses of the public keys by.
node-url	String	No	Node URL to apply a command to.

Example of the usage:

$ remme public-key get-list \
      --address=1120076ecf036e857f42129b58303bcf1e03723764a1702cbe98529802aad8514ee3cf \
      --node-url=node-genesis-testnet.remme.io
{
    "result": {
        "public_key_addresses": [
            "a23be10b3aad1b4a98f338c71d6dcdb2aa2f296c7e31fb400615e335dc10dd1d4f62bf",
            "a23be14b362514d624c1985277005327f6fc40413fb090eee6fccb673a32c9809060ff"
        ]
    }
}

Implemented

— Command line interface's command.
— Service to get the account public keys of the public key class.

References

CLI framework — https://click.palletsprojects.com/en/7.x
Library to interact with Remme-core — https://github.com/Remmeauth/remme-client-python

codecov-io · 2019-04-16T16:31:03Z

Codecov Report

Merging #16 into develop will increase coverage by 0.68%.
The diff coverage is 97.95%.

@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
+ Coverage    95.03%   95.71%   +0.68%     
===========================================
  Files           10       15       +5     
  Lines          161      210      +49     
===========================================
+ Hits           153      201      +48     
- Misses           8        9       +1

Impacted Files	Coverage Δ
cli/public_key/help.py	`100% <100%> (ø)`
cli/entrypoint.py	`100% <100%> (ø)`	⬆️
cli/public_key/forms.py	`100% <100%> (ø)`
cli/public_key/service.py	`100% <100%> (ø)`
cli/public_key/cli.py	`100% <100%> (ø)`
cli/public_key/interfaces.py	`66.66% <66.66%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850d3a3...3a6a41e. Read the comment docs.

…i into get-list-of-public-keys-by-account-address

…t-list-of-public-keys-by-account-address

dmytrostriletskyi · 2019-04-24T12:55:01Z

README.md

@@ -139,6 +140,26 @@ $ remme account transfer-tokens \
 }
 ```

+### Public key
+
+Get list of the public keys by account address — ``remme public-key get-list``:


Get list of the public keys ... > Get a list of the addresses of the public keys....

Apply the same to the code and tests documentation.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:55:28Z

README.md

+
+| Arguments | Type   | Required | Description                                |
+| :-------: | :----: | :------: | ------------------------------------------ |
+| address   | String | Yes      | Address to get list of the public keys by. |


Apply the comment above to the argument description.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:56:16Z

README.md

@@ -174,7 +195,7 @@ $ docker exec -it remme-core-cli bash

 And now being in the container, you can develop the project. For instance, run tests and linters:

-```bash
+```bashpytest -vv tests/


Revert this change, please.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:56:36Z

cli/public_key/cli.py

+    print_result,
+)
+
+loop = asyncio.get_event_loop()


You do not need it anymore here.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:58:25Z

cli/public_key/cli.py

+    address = arguments.get('address')
+    node_url = arguments.get('node_url')
+
+    remme = Remme(network_config={'node_address': str(node_url) + ':8080'})


Follow this style, please.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:58:41Z

cli/public_key/forms.py

@@ -0,0 +1,18 @@
+"""
+Provide forms for command line interface's account commands.


account > public key.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T12:59:44Z

cli/public_key/service.py

+        """
+        Get list of the public keys by account address.
+        """
+        public_keys = loop.run_until_complete(self.service.public_key_storage.get_account_public_keys(address=address))


Remember to handle Exception and write tests for it.

@dmytrostriletskyi, done.

dmytrostriletskyi · 2019-04-24T14:05:54Z

tests/public_key/test_get_public_keys.py

+    public_key_addresses = json.loads(result.output).get('result').get('public_key_addresses')
+
+    assert PASSED_EXIT_FROM_COMMAND_CODE == result.exit_code
+    assert isinstance(public_key_addresses, list)


Add checking that list is empty.

@dmytrostriletskyi, done.

dmytrostriletskyi and others added 2 commits April 16, 2019 17:28

Create dictionary to pretty json util

756d8f1

Create command line interface for function get account public keys

e41fea5

anastasiia-bilova requested review from dmytrostriletskyi and Alladin9393 April 16, 2019 16:27

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 4624c3e to 9b1c09d Compare April 16, 2019 19:46

anastasiia-bilova added 2 commits April 17, 2019 20:06

Merge branch 'pretty-json-util' of github.com:Remmeauth/remme-core-cl…

45c80fd

…i into get-list-of-public-keys-by-account-address

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

67514d1

…t-list-of-public-keys-by-account-address

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 9b1c09d to 67514d1 Compare April 17, 2019 17:07

Create positive and negative tests for function get public keys

40b7c70

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 14eb5f3 to 40b7c70 Compare April 18, 2019 14:02

anastasiia-bilova added 2 commits April 22, 2019 19:59

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

099b556

…t-list-of-public-keys-by-account-address

Create tests and add validation forms

3cf9c52

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 25eee14 to 3cf9c52 Compare April 23, 2019 09:56

anastasiia-bilova requested review from Annitra and removed request for Alladin9393 April 23, 2019 10:20

Annitra approved these changes Apr 24, 2019

View reviewed changes

anastasiia-bilova added 3 commits April 24, 2019 14:48

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

1ac5d8e

…t-list-of-public-keys-by-account-address

Small refactor implementation

375919d

Merge branch 'develop' of github.com:Remmeauth/remme-core-cli into ge…

73d5a43

…t-list-of-public-keys-by-account-address

dmytrostriletskyi suggested changes Apr 24, 2019

View reviewed changes

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 4c5d483 to 51e381b Compare April 24, 2019 14:02

dmytrostriletskyi approved these changes Apr 24, 2019

View reviewed changes

Apply review comments, add tests

3a6a41e

anastasiia-bilova force-pushed the get-list-of-public-keys-by-account-address branch from 51e381b to 3a6a41e Compare April 24, 2019 14:09

anastasiia-bilova merged commit ef7ecd5 into develop Apr 24, 2019

delete-merged-branch bot deleted the get-list-of-public-keys-by-account-address branch April 24, 2019 14:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get list of the public keys by account address on which these keys depend #16

Get list of the public keys by account address on which these keys depend #16

anastasiia-bilova commented Apr 16, 2019 •

edited

Loading

codecov-io commented Apr 16, 2019 •

edited

Loading

dmytrostriletskyi Apr 24, 2019 •

edited

Loading

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

dmytrostriletskyi Apr 24, 2019

anastasiia-bilova Apr 24, 2019

		@@ -0,0 +1,18 @@
		"""
		Provide forms for command line interface's account commands.

Get list of the public keys by account address on which these keys depend #16

Get list of the public keys by account address on which these keys depend #16

Conversation

anastasiia-bilova commented Apr 16, 2019 • edited Loading

Jira references

Description

Implemented

References

codecov-io commented Apr 16, 2019 • edited Loading

Codecov Report

dmytrostriletskyi Apr 24, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anastasiia-bilova commented Apr 16, 2019 •

edited

Loading

codecov-io commented Apr 16, 2019 •

edited

Loading

dmytrostriletskyi Apr 24, 2019 •

edited

Loading