Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfiguring the client (via Start Config packet) breaks it sometimes #62

Closed
2 of 3 tasks
VidTu opened this issue Apr 27, 2024 · 0 comments
Closed
2 of 3 tasks
Labels
bug Something isn't working

Comments

@VidTu
Copy link

VidTu commented Apr 27, 2024

Describe the bug
Reconfiguring a client with Start Configuration packet breaks the mod until the game is restarted.

To Reproduce
Steps to reproduce the behavior:

  1. Download Velocity (or any proxy that used RECONFIG packets to switch between servers) for 1.20.5.
  2. Configure it for two backend (1.20.5 "vanilla" servers used in testing without ViaVersion or any other protocol hacks, will possibly break all 1.20.2+ with ViaVersion) servers.
  3. Join the proxy. (connect to the first backend through Velocity)
  4. Attempt to switch to second backend.
  5. It kicks you. Sometimes it does, sometimes it doesn't. Sometimes it locks you from accessing the worls. Fully relogging into the proxy and then switching servers a few times (both relogging and switching) should reliably reproduce the bug.

Expected behavior
This shouldn't happen like in vanilla client.

Screenshots

Runtime info (please complete the following information):

  • OS: Win11
  • Minecraft version: 1.20.5 (Fabric)
  • Mod version: 0.2.0+beta.7.151 (509a207)
  • Mod branch: ver/1.20.6 (ig?...)

Crash reports / logs
https://paste.gg/p/VidTu/00091feda94d4637876a8084c1039bec (both deobf and obf)

Other mods
First log paste has StackDeobfuscator used for meaningful logs.
Second paste has only Fabric (w/o API) + VMP.

Checklist

  • I am using the official version of the mod.
  • I tried the latest development version but the issue persists.
  • I searched for similar open issues and could not find an existing bug report on this.

Additional context
This doesn't happen in Vanilla no matter how hard I try.
Dev version wasn't tested but there are no significant changes.

@VidTu VidTu added the bug Something isn't working label Apr 27, 2024
@ishland ishland closed this as completed in b8d8a18 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant