Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix that enables rendering additionalProperties set to true. #597

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Bugfix that enables rendering additionalProperties set to true. #597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f20b95
Fixed a bug that prevented additionalProperties holding a boolean to …
m-mohr Aug 7, 2018
ef3c532
Improved handling for additionalProperties holding a boolean.
m-mohr Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/models/Schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ function buildFields(
sortByRequired(fields, schema.required);
}

if (typeof additionalProps === 'object') {
if (typeof additionalProps === 'object' || typeof additionalProps === 'boolean') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if additionalProperties === false you should not push "additional properties" field, change this to checking if it is implicit true:

if (typeof additionalProps === 'object' || additionalProps === true) {

fields.push(
new FieldModel(
parser,
Expand Down