Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2: Set color form theme.colors.primary.main #1491

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Conversation

ajeetshah
Copy link
Contributor

@ajeetshah ajeetshah commented Jan 4, 2021

H2: Set color form theme.colors.primary.main so that it can be customized.

@RomanHotsiy
Copy link
Member

It would make sense to add an extra theme toggle for h1 and h2 tags instead of changing the color of h2. Right now h2 is black but will get primary color when this PR is merged which is may be not the desired behavior for every Redoc user.

What do you think?

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support a separate theme toggle.

@west1cles
Copy link

An extra theme toggle for H1, H2 and H3 would be 👍

@Oprysk
Copy link
Contributor

Oprysk commented Mar 23, 2022

@ajeetshah Thanks for your contribution and sorry for delay 🙈

We've decided to use theme.colors.text.primary for all heading levels, as it looks more convenient here.

@Oprysk Oprysk dismissed RomanHotsiy’s stale review March 23, 2022 15:53

not relevant anymore

@Oprysk Oprysk merged commit 25be934 into Redocly:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants