fix: constraints label details

Redocly · May 30, 2022 · eb0917d · eb0917d
1 parent 77104d6
commit eb0917d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/components/Fields/ArrayItemDetails.tsx b/src/components/Fields/ArrayItemDetails.tsx
@@ -4,9 +4,20 @@ import { ConstraintsView } from './FieldContstraints';
 import { Pattern } from './Pattern';
 import { SchemaModel } from '../../services';
 import styled from '../../styled-components';
+import { OptionsContext } from '../OptionsProvider';
 
 export function ArrayItemDetails({ schema }: { schema: SchemaModel }) {
-  if (!schema || (schema.type === 'string' && !schema.constraints.length)) return null;
+  const { hideSchemaPattern } = React.useContext(OptionsContext);
+  if (
+    !schema ||
+    (schema.type === 'string' && !schema.constraints.length) ||
+    ((!schema?.pattern || hideSchemaPattern) &&
+      !schema.items &&
+      !schema.displayFormat &&
+      !schema.constraints.length)
+  ) {
+    return null;
+  }
 
   return (
     <Wrapper>

diff --git a/src/components/Parameters/Parameters.tsx b/src/components/Parameters/Parameters.tsx
@@ -80,7 +80,9 @@ export function BodyContent(props: {
         return (
           <>
             {description !== undefined && <Markdown source={description} />}
-            <ConstraintsView constraints={schema?.constraints || []} />
+            {schema?.type === 'object' && (
+              <ConstraintsView constraints={schema?.constraints || []} />
+            )}
             <Schema
               skipReadOnly={isRequestType}
               skipWriteOnly={!isRequestType}

diff --git a/src/components/Responses/ResponseDetails.tsx b/src/components/Responses/ResponseDetails.tsx
@@ -24,7 +24,9 @@ export class ResponseDetails extends React.PureComponent<{ response: ResponseMod
           {({ schema }) => {
             return (
               <>
-                <ConstraintsView constraints={schema?.constraints || []} />
+                {schema?.type === 'object' && (
+                  <ConstraintsView constraints={schema?.constraints || []} />
+                )}
                 <Schema skipWriteOnly={true} key="schema" schema={schema} />
               </>
             );