-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMG-Electrochem #2316
base: main
Are you sure you want to change the base?
RMG-Electrochem #2316
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18d15d7 - Browse repository at this point
Copy the full SHA 18d15d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fed4eed - Browse repository at this point
Copy the full SHA fed4eedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07d5dcc - Browse repository at this point
Copy the full SHA 07d5dccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69cd7a9 - Browse repository at this point
Copy the full SHA 69cd7a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a838a9 - Browse repository at this point
Copy the full SHA 7a838a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fad4adf - Browse repository at this point
Copy the full SHA fad4adfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c943b7 - Browse repository at this point
Copy the full SHA 5c943b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f03438 - Browse repository at this point
Copy the full SHA 3f03438View commit details -
Configuration menu - View commit details
-
Copy full SHA for d64a296 - Browse repository at this point
Copy the full SHA d64a296View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5286352 - Browse repository at this point
Copy the full SHA 5286352View commit details -
added updated charge method and revised
update
Molecule methodthe update method now updates lone pairs before updating charge
Configuration menu - View commit details
-
Copy full SHA for 9f2de34 - Browse repository at this point
Copy the full SHA 9f2de34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eae0c3 - Browse repository at this point
Copy the full SHA 5eae0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4212fa - Browse repository at this point
Copy the full SHA b4212faView commit details -
try to generate_resonance_structures, and return a deep copy of the m…
…olecule if it fails
Configuration menu - View commit details
-
Copy full SHA for 0289b79 - Browse repository at this point
Copy the full SHA 0289b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for edd0129 - Browse repository at this point
Copy the full SHA edd0129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 378b598 - Browse repository at this point
Copy the full SHA 378b598View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d5e587 - Browse repository at this point
Copy the full SHA 9d5e587View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b8adff - Browse repository at this point
Copy the full SHA 8b8adffView commit details -
however, we still need better thermo
Configuration menu - View commit details
-
Copy full SHA for 6b31a06 - Browse repository at this point
Copy the full SHA 6b31a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb389a - Browse repository at this point
Copy the full SHA 8eb389aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ee890a - Browse repository at this point
Copy the full SHA 9ee890aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2095b - Browse repository at this point
Copy the full SHA eb2095bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 069444a - Browse repository at this point
Copy the full SHA 069444aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 811bcbc - Browse repository at this point
Copy the full SHA 811bcbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c094955 - Browse repository at this point
Copy the full SHA c094955View commit details -
Configuration menu - View commit details
-
Copy full SHA for edfb710 - Browse repository at this point
Copy the full SHA edfb710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78e7f76 - Browse repository at this point
Copy the full SHA 78e7f76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9114451 - Browse repository at this point
Copy the full SHA 9114451View commit details -
Configuration menu - View commit details
-
Copy full SHA for 456ed8e - Browse repository at this point
Copy the full SHA 456ed8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2201ab - Browse repository at this point
Copy the full SHA a2201abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 536eb36 - Browse repository at this point
Copy the full SHA 536eb36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f89e3 - Browse repository at this point
Copy the full SHA 96f89e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a832c5 - Browse repository at this point
Copy the full SHA 5a832c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e48b43 - Browse repository at this point
Copy the full SHA 6e48b43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 597bb66 - Browse repository at this point
Copy the full SHA 597bb66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a06b9 - Browse repository at this point
Copy the full SHA 33a06b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27f2e72 - Browse repository at this point
Copy the full SHA 27f2e72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58da613 - Browse repository at this point
Copy the full SHA 58da613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a57e75 - Browse repository at this point
Copy the full SHA 7a57e75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ffbfb7 - Browse repository at this point
Copy the full SHA 3ffbfb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b9e4d - Browse repository at this point
Copy the full SHA 30b9e4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80b5d98 - Browse repository at this point
Copy the full SHA 80b5d98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6147486 - Browse repository at this point
Copy the full SHA 6147486View commit details -
filter out resonance structures that try to put - charges on Li
fix resonance bug (squash)
Configuration menu - View commit details
-
Copy full SHA for 5f413af - Browse repository at this point
Copy the full SHA 5f413afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad20ae - Browse repository at this point
Copy the full SHA 4ad20aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffd7e22 - Browse repository at this point
Copy the full SHA ffd7e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58e5061 - Browse repository at this point
Copy the full SHA 58e5061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17a3c63 - Browse repository at this point
Copy the full SHA 17a3c63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c4fbde - Browse repository at this point
Copy the full SHA 2c4fbdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 638b864 - Browse repository at this point
Copy the full SHA 638b864View commit details -
Configuration menu - View commit details
-
Copy full SHA for 998ffb1 - Browse repository at this point
Copy the full SHA 998ffb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6013c5 - Browse repository at this point
Copy the full SHA a6013c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4410294 - Browse repository at this point
Copy the full SHA 4410294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f06814 - Browse repository at this point
Copy the full SHA 4f06814View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53f214c - Browse repository at this point
Copy the full SHA 53f214cView commit details -
add handling ArrheniusChargeTransfer and fix handling SurfaceChargeTr…
…ansfer for rms output
Configuration menu - View commit details
-
Copy full SHA for 9cbf444 - Browse repository at this point
Copy the full SHA 9cbf444View commit details -
Revert "Remove charge transfer types from average_kinetics (to be rev…
…erted)" This reverts commit 2180175. I also tweaked it a little bit.
Configuration menu - View commit details
-
Copy full SHA for 732f057 - Browse repository at this point
Copy the full SHA 732f057View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec47b8 - Browse repository at this point
Copy the full SHA 8ec47b8View commit details -
1) Enable fitting of ArrheniusChargeTransferBM 2) if the BM fit is bad: E0 < 0, A > 1e30 or abs(n) > 5 just average the kinetics
Configuration menu - View commit details
-
Copy full SHA for ba2d9f9 - Browse repository at this point
Copy the full SHA ba2d9f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9697e62 - Browse repository at this point
Copy the full SHA 9697e62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fa4dc1 - Browse repository at this point
Copy the full SHA 3fa4dc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b06e552 - Browse repository at this point
Copy the full SHA b06e552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d0d4dd - Browse repository at this point
Copy the full SHA 1d0d4ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f5d8ec - Browse repository at this point
Copy the full SHA 7f5d8ecView commit details -
standardize ascend option in cross validate
ascend based on original uncertainties and compute errors at that node in cross validate
Configuration menu - View commit details
-
Copy full SHA for 4e99274 - Browse repository at this point
Copy the full SHA 4e99274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f582ea - Browse repository at this point
Copy the full SHA 5f582eaView commit details -
add comment to averaged kinetics
(Commit updated by rwest during rebase: In the original commit the comment used to specify /why/ it was averaged, but it is added in the averaging method itself. The /why/, if needed, should be added elsewhere.)
Configuration menu - View commit details
-
Copy full SHA for 62fcb55 - Browse repository at this point
Copy the full SHA 62fcb55View commit details -
consistenty use dH298 do not estimate e0 = w0/10 when |dHrxn| > 0.4w0
Configuration menu - View commit details
-
Copy full SHA for b550f2a - Browse repository at this point
Copy the full SHA b550f2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6536ce - Browse repository at this point
Copy the full SHA c6536ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd505f6 - Browse repository at this point
Copy the full SHA dd505f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9a9ac - Browse repository at this point
Copy the full SHA 5d9a9acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1884255 - Browse repository at this point
Copy the full SHA 1884255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 125c9d8 - Browse repository at this point
Copy the full SHA 125c9d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aaedc8 - Browse repository at this point
Copy the full SHA 1aaedc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ceaa28e - Browse repository at this point
Copy the full SHA ceaa28eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a95fa2 - Browse repository at this point
Copy the full SHA 7a95fa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 814fbf7 - Browse repository at this point
Copy the full SHA 814fbf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc483b - Browse repository at this point
Copy the full SHA 4bc483bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c76e327 - Browse repository at this point
Copy the full SHA c76e327View commit details -
Configuration menu - View commit details
-
Copy full SHA for 425bdf7 - Browse repository at this point
Copy the full SHA 425bdf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 370a966 - Browse repository at this point
Copy the full SHA 370a966View commit details -
Configuration menu - View commit details
-
Copy full SHA for b949bec - Browse repository at this point
Copy the full SHA b949becView commit details -
only use kinetics that have arrhenius forms for tree generation
the TS solute data is used only for rule fitting after tree is generated fix tab error
Configuration menu - View commit details
-
Copy full SHA for f899089 - Browse repository at this point
Copy the full SHA f899089View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bc3a7a - Browse repository at this point
Copy the full SHA 1bc3a7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 120e506 - Browse repository at this point
Copy the full SHA 120e506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28473b1 - Browse repository at this point
Copy the full SHA 28473b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dba75b - Browse repository at this point
Copy the full SHA 0dba75bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 837f0f1 - Browse repository at this point
Copy the full SHA 837f0f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc3c443 - Browse repository at this point
Copy the full SHA cc3c443View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5634365 - Browse repository at this point
Copy the full SHA 5634365View commit details -
Configuration menu - View commit details
-
Copy full SHA for a861172 - Browse repository at this point
Copy the full SHA a861172View commit details -
remove test that solvent is in initial species
this allows us to use parameters of similar solvents when the exact solvent isn't available
Configuration menu - View commit details
-
Copy full SHA for 64bb21a - Browse repository at this point
Copy the full SHA 64bb21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 335228a - Browse repository at this point
Copy the full SHA 335228aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7c4643 - Browse repository at this point
Copy the full SHA c7c4643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 572bd82 - Browse repository at this point
Copy the full SHA 572bd82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1df7896 - Browse repository at this point
Copy the full SHA 1df7896View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76aef1a - Browse repository at this point
Copy the full SHA 76aef1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05e12ce - Browse repository at this point
Copy the full SHA 05e12ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for a716e57 - Browse repository at this point
Copy the full SHA a716e57View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab3678b - Browse repository at this point
Copy the full SHA ab3678bView commit details -
Refactor some rate fitting in rule generation.
It was:: if n > 1: # big long block else: return None I inverted the check so we can return early, and outdent a huge block of code.
Configuration menu - View commit details
-
Copy full SHA for 87d5d4d - Browse repository at this point
Copy the full SHA 87d5d4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7823ad8 - Browse repository at this point
Copy the full SHA 7823ad8View commit details -
Fix ArrheniusBM.get_activation_energy unit test.
The E0 had been changed, but the expected Ea not updated.
Configuration menu - View commit details
-
Copy full SHA for d70da49 - Browse repository at this point
Copy the full SHA d70da49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 824cbb0 - Browse repository at this point
Copy the full SHA 824cbb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e479209 - Browse repository at this point
Copy the full SHA e479209View commit details -
modifed arrbm
fit_to_data
unit testTest now compares the fitted rate to the rate it was trained on to make sure they agree.
Configuration menu - View commit details
-
Copy full SHA for 6c352db - Browse repository at this point
Copy the full SHA 6c352dbView commit details -
TEMPORARY: set database branch to lithium
remove this commit before merging
Configuration menu - View commit details
-
Copy full SHA for f805d04 - Browse repository at this point
Copy the full SHA f805d04View commit details -
checks that the first group_atom.atomtype is either an appropriate charged atomtype or is a general version of an appropriate charged atomtype
Configuration menu - View commit details
-
Copy full SHA for 752d413 - Browse repository at this point
Copy the full SHA 752d413View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd4457c - Browse repository at this point
Copy the full SHA fd4457cView commit details
Commits on Jul 28, 2023
-
allow
cat
of regression diff to fail, print a warning insteadthis will allow the regression test results to all be reported even if there is such a huge difference between the dynamic and baseline that the system utilities cannot print it see: #2316 (comment)
Configuration menu - View commit details
-
Copy full SHA for 5df983b - Browse repository at this point
Copy the full SHA 5df983bView commit details