-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: RMG-Electrocat #2000
WIP: RMG-Electrocat #2000
Conversation
This pull request introduces 2 alerts when merging 8303ea1 into f3afdbf - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging e771940 into f3afdbf - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 4cbd3c4 into f3afdbf - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging c01dd20 into f3afdbf - view on LGTM.com new alerts:
|
c01dd20
to
7386926
Compare
This pull request introduces 2 alerts when merging 7386926 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging b84681e into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging d21a9d6 into 1e21621 - view on LGTM.com new alerts:
|
c4179bc
to
f8ebdec
Compare
This pull request introduces 6 alerts when merging f8ebdec into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 050e5f8 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 1689be1 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging dca2015 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 70ed641 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 3a3031a into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 235bb03 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging bb32d7e into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 5384de3 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 6 alerts when merging 3f64812 into 1e21621 - view on LGTM.com new alerts:
|
This pull request introduces 11 alerts when merging 6234f31 into a4f06da - view on LGTM.com new alerts:
|
This pull request introduces 11 alerts when merging 0c19f20 into a4f06da - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 47.83% 47.50% -0.33%
==========================================
Files 102 88 -14
Lines 27116 23304 -3812
Branches 6957 6062 -895
==========================================
- Hits 12971 11071 -1900
+ Misses 12752 11072 -1680
+ Partials 1393 1161 -232
Continue to review full report at Codecov.
|
This pull request introduces 11 alerts when merging ce8c958 into a4f06da - view on LGTM.com new alerts:
|
ce8c958
to
d601bac
Compare
This pull request introduces 11 alerts when merging d601bac into a4f06da - view on LGTM.com new alerts:
|
This pull request introduces 11 alerts when merging 9d05913 into a4f06da - view on LGTM.com new alerts:
|
This pull request introduces 11 alerts when merging e17bdef into a4f06da - view on LGTM.com new alerts:
|
This pull request introduces 9 alerts when merging 6c26a6c into a4f06da - view on LGTM.com new alerts:
|
87127f2
to
091fe9b
Compare
This pull request introduces 3 alerts when merging 091fe9b into 336273d - view on LGTM.com new alerts:
|
This PR seems abandoned and should likely be closed. @davidfarinajr is this PR still in progress? |
Nope, we can close this. Let's make sure not to delete this branch though in case this work is picked up in the future. |
Thanks for the quick reply! Since we can always restore this branch if we decide to revive it, I will go ahead and delete it now for organization's sake. |
fyi @rwest , this branch could be useful if electrocat work is resumed. |
Thanks! Can you recall which of these are worth saving?
|
oof, forgot I had that many branches 😆. I'm not sure, I'd go with the one that has the most recent commits. I do remember |
This is a WIP PR for RMG-electrocat. The current goals of this PR are:
Unanswered questions