Fixes bug in LsiModel that occurs when id2word is a Python 3 dictionary. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Jan 23, 2017
| @@ -298,7 +298,8 @@ def __init__(self, corpus=None, num_topics=200, id2word=None, chunksize=20000, | |||
| self.id2word = utils.dict_from_corpus(corpus) | |||
| self.num_terms = len(self.id2word) | |||
| else: | |||
| self.num_terms = 1 + max([-1] + self.id2word.keys()) | |||
| self.num_terms = ( | |||
| 1 + max(self.id2word.keys()) if self.id2word else -1) | |||
There was a problem hiding this comment.
Looks good but keep the expression on one line please.
|
Done. |
piskvorky
reviewed
Jan 23, 2017
| @@ -298,8 +298,7 @@ def __init__(self, corpus=None, num_topics=200, id2word=None, chunksize=20000, | |||
| self.id2word = utils.dict_from_corpus(corpus) | |||
| self.num_terms = len(self.id2word) | |||
| else: | |||
| self.num_terms = ( | |||
| 1 + max(self.id2word.keys()) if self.id2word else -1) | |||
| self.num_terms = 1 + max(self.id2word.keys()) if self.id2word else -1 | |||
There was a problem hiding this comment.
Please put brackets around the ternary expression, its reading is a little ambiguous / confusing now (1 + not included).
|
Thanks @cvangysel ! CC @tmylk LGTM. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message "you cannot concatenate dictionary keys with a list" is thrown when passing dictionary id2word to
gensim.models.lsimodel.LsiModelin Python 3.