IFU to v2.0.4 #14
Merged
IFU to v2.0.4 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gpt-neox adoption
Follow xFormers's DISTPATCH_BOOL. Haven't tested it on Windows.
fixed cross attention typeerror
|
A new environment variable "FLASH_ATTENTION_INTERNAL_ENABLE_TIME_KERNEL" can switch the output of kernel running time |
|
[BUGs] Previously in older version of FA, we create tensors z and softmax_lse matrix of max sequence lengths with no padding for grouped gemm. But the strides for each batch for the tensors are different. This behaviour will cause wrong result from CK. Fixing it. |
…Platform/flash-attention into junhzhan/ifu-v2.0.0
Add MQA & GQA
|
Please remove *_hip.hpp |
jayz0123
force-pushed
the
junhzhan/ifu-v2.0.0
branch
from
d475794
to
02c234b
Compare
fsx950223
reviewed
Oct 30, 2023
.gitignore
Outdated
| @@ -24,7 +24,10 @@ var/ | |||
| .vscode/settings. | |||
|
|
|||
| # Generated files | |||
| csrc/flash_attn_rocm/src/*hip* | |||
There was a problem hiding this comment.
Yes, file names such as hip_flash_attention.cpp or hip_hacks.hpp are ignored too?
…Platform/flash-attention into junhzhan/ifu-v2.0.0
…Platform/flash-attention into junhzhan/ifu-v2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Unit Test Result: (PyTorch 2.0.0; ROCm 5.6)
3968 passed, 63 skipped
Current Performance on MI250: (docker pull rocm/pytorch:rocm5.7_ubuntu22.04_py3.10_pytorch_2.0.1)