Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized API for packed conditions #12

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

guangzlu
Copy link

@guangzlu guangzlu commented Aug 24, 2023

Optimized API for packed conditions, tensor copies are removed in qkvpacked and kvpacked conditions.
kv-packed-compare.xlsx
qkv-packed-compare.xlsx

Running time can reduce when using qkvpacked and kvpacked inputs.

@guangzlu guangzlu marked this pull request as draft August 24, 2023 09:25
@guangzlu guangzlu marked this pull request as ready for review August 25, 2023 03:16
Copy link

@jayz0123 jayz0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sabreshao sabreshao merged commit d394549 into flash_attention_for_rocm Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants