New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in accounts list #146

Closed

jackrua wants to merge 3 commits into RIP-Comm:main from jackrua:main

Contributor

jackrua commented Feb 4, 2024

Two fixes:

First fix (the important one):

Addresses issue Accounts list is not updating #140.
The problem is already illustrated at the issue page, I tried to make as little changes as possible to the original code. Now when you query sossoldi.db, you also get the accounts that have no transactions.

Second fix:

Added a little padding since the "Delete Account" button is partially covered on Pixel 5 (and completely covered on my personal phone) by the "Update Account" button. See bottom of picture below:

jackrua added 3 commits

February 4, 2024 18:16


          Fixed left join losing accounts without transactions

e85bdb9


          "Delete account" button partially covered by "Update account" bar

a9dc196


          Merge branch 'main' into main

ecf123f

jackrua closed this

Contributor Author

jackrua commented Feb 4, 2024

My bad! I just saw that the fix has been already implemented ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet