Transactions date filtering + settings improvement #129
Conversation
lucaantonelli
commented
Dec 21, 2023
lucaantonelli
commented
- Add notification settings
- Update layouts and color to match figma
- Add filter for month on transactions tab with correct design on list
- Merge of transaction_list_tile.dart in transaction_list.dart to have only one widget
- Working create/update/delete of transactions
- Partial budget page improvement
- close transfers addition issue #88
. add notification settings . update layouts and color to match figma
. Add filter for month on transactions tab with correct design on list . merge of transaction_list_tile.dart in transaction_list.dart to have only one widget . Working create/update/delete of transactions . partial budget page improvement . close RIP-Comm#88
There was a problem hiding this comment.
Great work! I just one question and two small suggestions/requests. I saw that you added the notification toggle but we still need to make it work right?
For the suggestions:
- I see that the bug for the transfer is fixed but a user is still able to make a transaction from an account to the same one (ex. Revolut -> Revolut) which is a bit strange to me, it would be better if we could avoid this kind of behaviour. Of course it depends on how much time this change would take, if it's too much let's leave it as is.
- The word "View:" in the Transactions page looks odd to me and seems unnecessary, I see it also in the Figma from @federicopozzato but if he agrees I would remove it since it should be clear to the user what they are seeing in that page (I know that this was already there but I just noticed and we could take advantage of this PR to remove it)
|
@theperu agreed👌 |
. Working totals in the widget when filtering in transactions tab . Remove text "View:" from transactions tab . Disable the selected account in "from" for "to" account selection, to avoid unwanted transfer on same account
|
@theperu i updated the code following your suggestions, and yes, actually the notifications settings is just graphically done. |
|
Super!! Other than that looks very good to me. If all of you agreed, we can surely merge. |
|
@mikev-cw Thanks! About the error, it might be about data, clearing in settings should solve it. |
. add dashboard provider for real data on home page . fix a bug in transactions list not showing some transaction
. add categories and account filtering fully working on transactions tab . add dashboard working with real data . improve custom widgets . update some query
|
I just did a lot of work on the PR! |
When switching between the income and expense filters, if a category or account was selected, the app would throw an error. Now, every time the selected category/account is pressed, it gets reset.
