rgb with only two params incorrectly parse color

[gerdasi]

Hey!

I'm using color package and have some local tests for invalid user input check. After recent release (4.0.2) couple of my tests started failing.
Previously rgb(255,2) color was invalid and now it returns [25, 5, 2].
The same goes for rgba(255,0) - it returns [25, 5, 0].

Is this expected behaviour? As far as I know, it should be invalid syntax 🤔 .
Thanks! 🙏

[gerdasi]

Seems like it's not related to color package because downgrading versions didn't help.

[Qix-]

rgb(255,2) is not valid syntax, right. Can you show me exactly what you're using to instantiate Color? This might be a color-string bug as I just upgraded a number of things over there. Downgrading color probably wouldn't do much.

[mastertheblaster]

can be reproduced with latest npm install color

[Qix-]

Yep, confirmed - this should be erroring. Regression introduced in 85e6f53 - I'll move this over to the color-string repository.

[Qix-]

Thanks for the report, sorry about that! Fix landed in 32f3e00, released as 1.8.2.

[mastertheblaster]

Thanks, seems it fixed the problem 💯

[Qix-]

No problem, thanks for confirming!

[gerdasi]

Thank you! 🎊