Fix broken tests using deprecated matplotlib function from 3.6.0 (closes #909) #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, it looks like there is a second upstream issue with aer being moved from qiskit.providers.aer to qiskit_aer: Qiskit/qiskit-aer#1526. Maybe pin aer to <0.11 here and then we can do a real fix for that in a separate PR? Or we could pin aer and matplotlib in a separate PR, then unpin matplotlib in this PR, and then unpin aer in the PR that fixes 0.11. |
|
Let's leave this PR as is. I'll quickly open a PR to pin both libraries. |
|
I merged #911, so you should be able to merge/rebase main and remove the matplotlib constraint now. |
|
Actually, I went ahead and did the above. I wanted to get the CI started since it takes a while. |
wshanks
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Matplotlib 3.6.0 deprecates
join()forGrouper, which is returned byget_shared_{x,y}_axes(). This means a deprecation warning is raised byMplCurveDrawer, which causes some tests to fail. See #909 for more.Details and comments
This PR fixes #909 as described in the issue. I have confirmed the tests pass locally on my machine (macOS Intel, Python 3.9).
Pinging relevant people
@wshanks @nkanazawa1989