Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qiskit-sphinx-theme requirement from ~=1.14.0rc1 to >=1.14.0, <2 #395

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2023

Updates the requirements on qiskit-sphinx-theme to permit the latest version.

Release notes

Sourced from qiskit-sphinx-theme's releases.

Qiskit Sphinx Theme 1.16.0

No changes since 1.16.0rc1. As documented in its release notes, the 1.16 release has a couple of small SEO and styling improvements:

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [qiskit-sphinx-theme](https://github.com/Qiskit/qiskit_sphinx_theme) to permit the latest version.
- [Release notes](https://github.com/Qiskit/qiskit_sphinx_theme/releases)
- [Changelog](https://github.com/Qiskit/qiskit_sphinx_theme/blob/main/docs_guide/release_notes.rst)
- [Commits](Qiskit/qiskit_sphinx_theme@1.14.0rc1...1.16.0)

---
updated-dependencies:
- dependency-name: qiskit-sphinx-theme
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 1, 2023
@garrison
Copy link
Member

garrison commented Sep 1, 2023

@Eric-Arellano, do you think we should continue to pin a maximum version, or just always use the latest version of qiskit-sphinx-theme? I'm leaning toward just always using the latest version, because I'm not even sure what I'd do to detect regressions short of going through each page every time we want to bump the version.

@Eric-Arellano
Copy link
Contributor

I would pin to <2 because we will make breaking changes. Otherwise, yeah, we don't need minor version pins anymore. The API is stable and we're now following semver properly.

@garrison
Copy link
Member

garrison commented Sep 1, 2023

I would pin to <2 because we will make breaking changes. Otherwise, yeah, we don't need minor version pins anymore. The API is stable and we're now following semver properly.

Great, thank you. I agree, pinning to < 2 makes the most sense in this case.

@garrison garrison changed the title Update qiskit-sphinx-theme requirement from ~=1.14.0rc1 to ~=1.16.0 Update qiskit-sphinx-theme requirement from ~=1.14.0rc1 to >=1.14.0, <2 Sep 1, 2023
@garrison garrison merged commit d183156 into main Sep 1, 2023
9 checks passed
@garrison garrison deleted the dependabot/pip/qiskit-sphinx-theme-approx-eq-1.16.0 branch September 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants