pn插件升级为apk插件问题 #294
Merged
pn插件升级为apk插件问题 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2、修复apk插件覆盖pn插件插件包名没有更新的bug;
|
pn插件在没有使用情况下使用apk插件升级，持久化文件中存储的包名还是pn插件的包名，常驻进程重启后Plugininfo.isDexExtracted状态判断出错。 |
jiongxuan
reviewed
Aug 11, 2017
| @@ -495,6 +495,15 @@ public void setType(int type) { | |||
| } | |||
|
|
|||
| /** | |||
| * 设置插件的包名 | |||
| */ | |||
| public void setPkgName(String pkgName){ | |||
There was a problem hiding this comment.
- 建议将“访问权限”改为Private，防止被外界误以为是可以直接调用的，导致出现问题
- 同时，建议将方法名改为“setPackageName”，和之前的getPackageName“遥相呼应”
| @@ -709,6 +718,7 @@ public void update(PluginInfo info) { | |||
| setVersion(info.getVersion()); | |||
| setPath(info.getPath()); | |||
| setType(info.getType()); | |||
| setPkgName(info.getPackageName()); | |||
There was a problem hiding this comment.
- 可以同时再设置下setAlias，防止出现“变成APK方案后，因别名发生改变而导致”的问题
- update方法上面的说明中，“插件名之类的不会被更新”字样可以被去掉
| @@ -443,7 +443,12 @@ public Context getApplicationContext() { | |||
| // 直接获取插件的Application对象 | |||
| // NOTE 切勿获取mLoader.mPkgContext，因为里面的一些方法会调用getApplicationContext（如registerComponentCallback） | |||
| // NOTE 这样会造成StackOverflow异常。所以只能获取Application对象（框架版本为3以上的会创建此对象） | |||
| return mLoader.mPluginObj.mApplicationClient.getObj(); | |||
| //entry中调用context.getApplicationContext时mApplicationClient还没被赋值，会导致空指针造成插件安装失败 | |||
|
Good，辛苦！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、修复entry中调用context导致插件安装失败的bug;
2、修复apk插件覆盖pn插件插件包名没有更新的bug;
Thank you for contributing! Let's make RePlugin better and better!
Now please tell us the following info for better understanding:
Summary
Description
The issue id of this Pull Request fixes and your general idea of implementation.