Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize a piece of code and repair one bug about compatibility of path separators for window and Linux #212

Merged
merged 4 commits into from
Jul 17, 2017

Conversation

wangfuda
Copy link
Contributor

@wangfuda wangfuda commented Jul 16, 2017

Summary

兼容不同系统上的路径分隔符表示,并基于Pattern.quote适配split的正则参数

Description

1.优化ReClassTransform类中的路径分割代码片段
2.修复ManifestAPI类中的路径分割bug,在windows下编译,{productFlavors}{buildTypes}均配置了的情况下,因为路径未被正确分割,gradle task名称中含有"\",会导致无法正确执行gradle task

@jiongxuan
Copy link
Contributor

您好,非常感谢您的PR!我们这就看下改动,没问题的话就Merge进来。

@wangyupeng1-iri @erhu 兄,辛苦评估下呗~

@wangyupeng1-iri wangyupeng1-iri merged commit f16444e into Qihoo360:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants