Plugin uninstall functionality optimized for synchronizing multiple p… #199
Conversation
| @@ -74,6 +74,9 @@ public void remove(String pn) { | |||
| JSONHelper.remove(mJson, i); | |||
| } | |||
| } | |||
| if (mMap.containsKey(pn)) { | |||
| mMap.remove(pn); | |||
| } | |||
| if (RePluginInternal.getAppContext().getApplicationContext() != null) { | ||
| IPC.sendLocalBroadcast2AllSync(RePluginInternal.getAppContext(), intent); | ||
| } else { | ||
| Tasks.init(); |
There was a problem hiding this comment.
RePlugin.onCreate内部也调用了Tasks.init，不如挪到attachBaseContext中靠前位置，这样这里就不用调用了。
| // 3. 给各进程发送广播，同步更新 | ||
| final Intent intent = new Intent(PluginInfoUpdater.ACTION_UNINSTALL_PLUGIN); | ||
| intent.putExtra("obj", info); | ||
| // 注意：attachBaseContext内部获取getApplicationContext会为空，则此情况仅在UI线程进行更新 |
There was a problem hiding this comment.
这块儿的注释还是不够清晰。建议改为：
“注意：若在attachBaseContext中调用此方法，则由于此时getApplicationContext为空，导致发送广播时会出现空指针异常。则应该Post一下，待getApplicationContext有值后再发送广播”
| @@ -73,6 +73,12 @@ | |||
| public static final String LOCAL_PLUGIN_APK_LIB_DIR = "p_n"; | |||
|
|
|||
| /** | |||
| * "纯APK"插件同版本升级时插件、Odex、Native（SO库）的用于覆盖的存放目录 | |||
| * Added by Zhiwei Liu | |||
There was a problem hiding this comment.
建议去掉Added by 字样，因为开源后的PR可以体现改动点。
| @@ -201,7 +201,19 @@ private boolean verifySignature(PackageInfo pi, String path) { | |||
| } | |||
|
|
|||
| private boolean checkVersion(PluginInfo instPli, PluginInfo curPli) { | |||
There was a problem hiding this comment.
建议改下返回值为int，-1为instPli小于curPli，1为instPli大于curPli，0为两者相等，这样就不必再checkVersion中做set操作了
| LogDebug.d(TAG, "isSameVersion: same version. " + | ||
| "inst_ver=" + instPli.getVersion() + "; cur_ver=" + curPli.getVersion()); | ||
| } | ||
| instPli.setIsPendingCover(true); |
There was a problem hiding this comment.
建议改下返回值为int，-1为instPli小于curPli，1为instPli大于curPli，0为两者相等，这样就不必再checkVersion中做set操作了
| if (instPli.getVersion() > curPli.getVersion()) { | ||
| // 高版本升级 | ||
| instPli.setIsThisPendingUpdateInfo(true); | ||
| curPli.setPendingUpdate(instPli); |
There was a problem hiding this comment.
如果已经要做升级了，应该需要做一次setPendingCover(null)和setPendingDelete(null)，之后的操作覆盖之前的。并打个Log出来
| curPli.setPendingUpdate(instPli); | ||
| } else if (instPli.getVersion() == curPli.getVersion()){ | ||
| // 同版本覆盖 | ||
| curPli.setPendingCover(instPli); |
There was a problem hiding this comment.
同理，应该setPendingDelete(null)，但无需setPendingUpdate，因为在updatePendingUpdate时就已经return了（建议加个注释说明一下）
| } | ||
| } finally { | ||
| try { | ||
| FileUtils.forceDelete(newPi.getApkFile().getParentFile()); |
There was a problem hiding this comment.
建议这么写，这样减少歧义：
File parentDir = newPi.getApkFile().getParentFile();
FileUtils.forceDelete(parentDir);
…rocess plugin information
Thank you for contributing! Let's make RePlugin better and better!
Now please tell us the following info for better understanding:
Summary
Description
The issue id of this Pull Request fixes and your general idea of implementation.