Skip to content
GitHub Actions / Clippy (MSRV) failed May 6, 2024 in 0s

Clippy (MSRV)

9 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 0
Note 0
Help 0

Versions

  • rustc 1.60.0 (7737e0b5c 2022-04-04)
  • cargo 1.60.0 (d1fd9fe 2022-03-01)
  • clippy 0.1.60 (7737e0b 2022-04-04)

Annotations

Check failure on line 784 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait

error: using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:784:33
    |
784 |             test_proof_size(11, circuit.clone(), &params, &vk);
    |                                 ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `circuit`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 737 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait

error: using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:737:33
    |
737 |             test_proof_size(11, circuit.clone(), &params, &vk);
    |                                 ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `circuit`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 689 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait

error: using `clone` on type `utilities::lookup_range_check::tests::short_range_check::MyCircuit<pasta_curves::Fp>` which implements the `Copy` trait
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:689:33
    |
689 |             test_proof_size(11, circuit.clone(), &params, &vk);
    |                                 ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `circuit`
    |
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 791 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant clone

error: redundant clone
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:791:38
    |
791 |                     proofs.push(proof.clone());
    |                                      ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:791:33
    |
791 |                     proofs.push(proof.clone());
    |                                 ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check failure on line 744 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant clone

error: redundant clone
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:744:38
    |
744 |                     proofs.push(proof.clone());
    |                                      ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:744:33
    |
744 |                     proofs.push(proof.clone());
    |                                 ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check failure on line 696 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

redundant clone

error: redundant clone
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:696:38
    |
696 |                     proofs.push(proof.clone());
    |                                      ^^^^^^^^ help: remove this
    |
    = note: `-D clippy::redundant-clone` implied by `-D warnings`
note: this value is dropped without further use
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:696:33
    |
696 |                     proofs.push(proof.clone());
    |                                 ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

Check failure on line 656 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

unused variable: `proofs`

error: unused variable: `proofs`
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:656:17
    |
656 |             let proofs= {
    |                 ^^^^^^ help: if this is intentional, prefix it with an underscore: `_proofs`
    |
    = note: `-D unused-variables` implied by `-D warnings`

Check failure on line 93 in halo2_gadgets/src/utilities/test_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

function is never used: `write_all_test_case`

error: function is never used: `write_all_test_case`
  --> halo2_gadgets/src/utilities/test_circuit.rs:93:15
   |
93 | pub(crate) fn write_all_test_case<W: Write>(
   |               ^^^^^^^^^^^^^^^^^^^

Check failure on line 58 in halo2_gadgets/src/utilities/test_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

function is never used: `test_proof_size`

error: function is never used: `test_proof_size`
  --> halo2_gadgets/src/utilities/test_circuit.rs:58:15
   |
58 | pub(crate) fn test_proof_size<C>(
   |               ^^^^^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`