Skip to content

Commit

Permalink
Update EccPointQ enum
Browse files Browse the repository at this point in the history
  • Loading branch information
ConstanceBeguier committed Jul 9, 2024
1 parent 1bb738a commit 3c03e46
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ use std::ops::Deref;

/// `EccPointQ` can hold either a public or a private ECC Point
#[derive(Debug, Clone)]
pub enum EccPointQ {
pub enum EccPointQ<'a> {
PublicPoint(pallas::Affine),

Check warning on line 23 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

field `0` is never read

warning: field `0` is never read --> halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs:23:17 | 23 | PublicPoint(pallas::Affine), | ----------- ^^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 23 | PublicPoint(()), | ~~

Check warning on line 23 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs

View workflow job for this annotation

GitHub Actions / Bitrot check

field `0` is never read

Check warning on line 23 in halo2_gadgets/src/sinsemilla/chip/hash_to_point.rs

View workflow job for this annotation

GitHub Actions / Bitrot check

field `0` is never read
#[allow(dead_code)]
// We will use private point for ZSA
// PrivatePoint(&'a NonIdentityEccPoint),
PrivatePoint(&'a NonIdentityEccPoint),
}

impl<Hash, Commit, Fixed, Lookup> SinsemillaChip<Hash, Commit, Fixed, Lookup>
Expand Down

0 comments on commit 3c03e46

Please sign in to comment.