Fix/test pass overrides #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
reviewed
Feb 23, 2020
| @@ -762,5 +762,39 @@ def test_trainer_min_steps_and_epochs(tmpdir): | |||
| trainer.current_epoch > 0, "Model did not train for at least min_steps" | |||
|
|
|||
|
|
|||
| def test_testpass_overrides(tmpdir): | |||
| hparams = tutils.get_hparams() | |||
| from pytorch_lightning.utilities.debugging import MisconfigurationException | |||
There was a problem hiding this comment.
this can be loaded at the beginning of the file
Borda
reviewed
Feb 23, 2020
|
This is breaking master, it shall be fixed... @MattPainter01? |
Merged
Closed
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* Fix test requiring both test_step and test_end * Add test Co-authored-by: William Falcon <waf2107@columbia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909
I've added a test too, let me know if it's unnecessary.