Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop torchvision, tests only #797

Merged
merged 3 commits into from
Feb 11, 2020
Merged

drop torchvision, tests only #797

merged 3 commits into from
Feb 11, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 7, 2020

What does this PR do?

Fixes #694. Removing torchvision dependency since it is used only for testing

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@Borda Borda added bug Something isn't working feature Is an improvement or enhancement labels Feb 7, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 7, 2020
@Borda Borda changed the title drop torchvision, tests only [wip] drop torchvision, tests only Feb 7, 2020
@Borda Borda requested review from neggert and a team February 7, 2020 21:27
@williamFalcon
Copy link
Contributor

@Borda rebase?

@williamFalcon williamFalcon merged commit af44583 into Lightning-AI:master Feb 11, 2020
@Borda Borda deleted the drop_torchvision branch February 11, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT problem with torchvision 0.5
2 participants