Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create single file in TensorBoardLogger #777

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Create single file in TensorBoardLogger #777

merged 2 commits into from
Feb 2, 2020

Conversation

festeh
Copy link
Contributor

@festeh festeh commented Jan 31, 2020

What does this PR do?

Fixes #740

The idea is to hack into add_hparams method and instead of creating new tfevents file use existing one.

@Borda Borda added the feature Is an improvement or enhancement label Jan 31, 2020
@Borda Borda added this to the 0.6.1 milestone Jan 31, 2020
@williamFalcon
Copy link
Contributor

@festeh mind rebasing?

@festeh
Copy link
Contributor Author

festeh commented Feb 2, 2020

@williamFalcon done

@williamFalcon williamFalcon merged commit b5cab7e into Lightning-AI:master Feb 2, 2020
@festeh festeh mentioned this pull request Apr 29, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7
Development

Successfully merging this pull request may close these issues.

TensorBoardLogger creates another tfevents file.
3 participants
@festeh @williamFalcon @Borda