for #330, use tqdm.auto in trainer #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will import the ipywidgets version of tqdm if available. This works nicely in notebooks by not filling up the log. In the terminal it will use the same old tqdm. We might also want to consider passing in the tqdm we want as an argument since there may be some edge cases where ipywidgets is available but the interface doesn't support it (e.g. vscode?) or isn't working. In which case people will get a warning message, but may want to configure it themselves.
Borda
approved these changes
Jan 26, 2020
| @@ -808,13 +808,13 @@ def run_pretrain_routine(self, model): | |||
| ref_model.on_train_start() | |||
| if not self.disable_validation and self.num_sanity_val_steps > 0: | |||
| # init progress bars for validation sanity check | |||
| pbar = tqdm.tqdm(desc='Validation sanity check', | |||
| pbar = tqdm(desc='Validation sanity check', | |||
| total=self.num_sanity_val_steps * len(self.get_val_dataloaders()), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #330
This will import the ipywidgets version of tqdm if available. This works nicely in notebooks by not filling up the log.
In the terminal it will use the same old tqdm.
We might also want to consider passing in the tqdm we want as an argument since there may be some edge cases where ipywidgets is available but the interface doesn't support it (e.g. vscode?) or isn't working. In which case people will get a warning message, but may want to configure it themselves.
Before submitting
What does this PR do?
Fixes #330 (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Especially @Borda
Did you have fun?
Make sure you had fun coding 馃檭
:)