Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where callback_metrics was replaced instead of updated #492

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fixed issue where callback_metrics was replaced instead of updated #492

merged 1 commit into from
Nov 12, 2019
+2 −2

Conversation

ryanwongsa
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #490 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ryanwongsa ryanwongsa mentioned this pull request Nov 11, 2019
Closed
@williamFalcon williamFalcon merged commit ba0a32c into Lightning-AI:master Nov 12, 2019
@williamFalcon
Copy link
Contributor

@ryanwongsa thanks!

@kuynzereb kuynzereb mentioned this pull request Nov 20, 2019
Closed
@kuynzereb kuynzereb mentioned this pull request Jan 9, 2020
Closed
@Drow999 Drow999 mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Early stopping conditioned on metric val_loss isn't recognised when setting the val_check_interval
2 participants
@ryanwongsa @williamFalcon