fix ONNX model save on GPU #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3145 +/- ##
======================================
Coverage 90% 90%
======================================
Files 84 84
Lines 8044 8048 +4
======================================
+ Hits 7225 7229 +4
Misses 819 819 |
Borda
reviewed
Aug 25, 2020
justusschock
approved these changes
Aug 25, 2020
rohitgr7
reviewed
Aug 25, 2020
rohitgr7
reviewed
Aug 26, 2020
|
This pull request is now in conflict... :( |
SkafteNicki
approved these changes
Aug 26, 2020
rohitgr7
reviewed
Aug 26, 2020
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
|
Great job! =) |
Borda
reviewed
Aug 26, 2020
| model.example_input_array = None | ||
| file_path = os.path.join(tmpdir, "model.onnx") | ||
| input_sample = np.random.randn(1, 28 * 28) | ||
| with pytest.raises(ValueError, match=f'Received `input_sample` of type {type(input_sample)}. Expected type is ' |
There was a problem hiding this comment.
Do we have test catching the second exception?
There was a problem hiding this comment.
nope. If it is required then I suggest we should add one for Tensorboard log_graph too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3144
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃