Retrieve last logged val from result by key #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-19 13:54:57 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3049 +/- ##
======================================
Coverage 90% 90%
======================================
Files 81 81
Lines 7673 7678 +5
======================================
+ Hits 6913 6918 +5
Misses 760 760 |
justusschock
changed the title
justusschock
requested review from
williamFalcon,
Borda,
ethanwharris,
nateraw and
teddykoker
awaelchli
approved these changes
Aug 19, 2020
| @@ -45,6 +45,12 @@ def __init__( | |||
| } | |||
| } | |||
|
|
|||
| def __getitem__(self, key: Union[str, Any]) -> Any: | |||
| try: | |||
| return super().__getitem__(key) | |||
There was a problem hiding this comment.
self.get(key) does not work?
rohitgr7
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If you log a key to the result object, the last logged step value can be retrieved by indexing with the name, even though it may have changed internally.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃