tracks all outputs including TBPTT and multiple optimizers #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-09 02:51:37 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2890 +/- ##
======================================
Coverage 90% 90%
======================================
Files 79 79
Lines 7236 7328 +92
======================================
+ Hits 6530 6617 +87
- Misses 706 711 +5 |
williamFalcon
changed the title
awaelchli
reviewed
Aug 9, 2020
Comment on lines
+636
to
+640
| try: | ||
| sample_obj = opt_idx_outputs[0][0] if isinstance(opt_idx_outputs[0], list) else opt_idx_outputs[0] | ||
| is_result_obj = len(epoch_output) > 0 and isinstance(sample_obj, Result) | ||
| except IndexError as e: | ||
| is_result_obj = False |
There was a problem hiding this comment.
@williamFalcon I believe this can be improved. The problem I see here is that, if anywhere else, for example in Result, an IndexError occurs then it will propagate to here and be treated wrongly. I highly recommend not to use exception handling for these types of control flow problems, as it can make debugging a lot more painful searching for the real origin. See also #2266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables behavior that was previously not possible:
Finishes #2354
Fixes #2320