Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shell injection vulnerability in subprocess call #2786

Merged

Conversation

bkhakshoor
Copy link
Contributor

@bkhakshoor bkhakshoor commented Jul 31, 2020

What does this PR do?

Fixed the shell injection vulnerability discussed in issue #2782. See issue for more detail.
I had trouble testing this, can you help me verify this is working properly?

Fixes #2782

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
    Not a significant change
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
    No, I had trouble testing these changes locally and in Circle, can you help me verify?
  • If you made a notable change (that affects users), did you update the CHANGELOG?
    No notable changes

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from a team July 31, 2020 22:32
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #2786 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2786   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          76      76           
  Lines        6787    6787           
======================================
  Hits         6150    6150           
  Misses        637     637           

@ananyahjha93
Copy link
Contributor

@bkhakshoor no worries, I will take look to verify if the changes work. For now, they are passing all the tests

@Borda Borda added allowed_pre_1.0 feature Is an improvement or enhancement distributed Generic distributed-related topic labels Aug 1, 2020
@mergify mergify bot requested a review from a team August 1, 2020 07:17
@mergify mergify bot requested a review from a team August 1, 2020 15:27
@williamFalcon williamFalcon merged commit 96eb6eb into Lightning-AI:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of shell=True could lead to shell injection
5 participants