.fit() returns last not best weights in ddp_spawn #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
changed the title
awaelchli
reviewed
Jul 9, 2020
| @@ -559,9 +560,13 @@ def ddp_train(self, process_idx, q, model, is_master=False, proc_offset=0): | |||
| torch.cuda.empty_cache() | |||
|
|
|||
| if self.global_rank == 0 and q is not None: | |||
| rank_zero_warn('cleaning up ddp environment...') | |||
| q.put(self.checkpoint_callback.best_model_path) | |||
There was a problem hiding this comment.
could we add a None check here for checkpoint_callback? because the user can set it to None, if they want.
See #2547
yukw777
reviewed
Jul 9, 2020
|
In ddp_spawn the model is only updated in a subprocess. Thus when .fit() ends the original model is still untrained. |
Borda
approved these changes
Jul 9, 2020
|
@williamFalcon ok and you use the queue to send back the best weight path to the main process in case the user wants the best weights for testing. got it. |
|
Hello @williamFalcon! Thanks for updating this PR.
Comment last updated at 2020-07-09 15:22:21 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2565 +/- ##
=======================================
+ Coverage 87% 91% +4%
=======================================
Files 70 70
Lines 5703 5718 +15
=======================================
+ Hits 4960 5209 +249
+ Misses 743 509 -234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2547