Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make loggers pickleable #2518

Merged
merged 3 commits into from
Jul 5, 2020
Merged

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Jul 5, 2020

What does this PR do?

we need logger pickling in #2512

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from a team July 5, 2020 23:17
@@ -78,7 +78,7 @@ def log_metrics(self, metrics, step):
@pytest.mark.parametrize("logger_class", [
TensorBoardLogger,
CometLogger,
MLFlowLogger,
# MLFlowLogger,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing this logger in #2502 so for now, it will not be picklable.

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #2518 into master will increase coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #2518    +/-   ##
=======================================
+ Coverage      88%     90%    +2%     
=======================================
  Files          69      69            
  Lines        5610    5628    +18     
=======================================
+ Hits         4942    5075   +133     
+ Misses        668     553   -115     

@awaelchli
Copy link
Member Author

awaelchli commented Jul 5, 2020

@williamFalcon these loggers are now picklable

  • TensorboardLogger
  • CometLogger
  • NeptuneLogger (was already)
  • TestTubelogger (was already)
    even if we call .experiment on them. when dumping them, we simply remove the _experiment object, which can be recreated from the state of the logger. See the test.

These two are not yet:

@awaelchli awaelchli marked this pull request as ready for review July 5, 2020 23:37
@williamFalcon williamFalcon merged commit 1098a0d into master Jul 5, 2020
@awaelchli awaelchli deleted the bugfix/make-logger-pickleable branch July 6, 2020 00:02
@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants