Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds tensorboard hparams logging test #2342

Merged
merged 10 commits into from
Jun 25, 2020
Merged

adds tensorboard hparams logging test #2342

merged 10 commits into from
Jun 25, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Jun 24, 2020 •
edited by Borda
Loading

Fixes #1217
Fixes #2023

@mergify mergify bot requested a review from a team June 24, 2020 02:08
@williamFalcon williamFalcon changed the title adds hparam logging test adds tensorboard hparams logging test Jun 24, 2020
@Borda Borda added bug Something isn't working ci Continuous Integration labels Jun 24, 2020
@mergify mergify bot requested a review from a team June 24, 2020 08:19
@pep8speaks
Copy link

pep8speaks commented Jun 24, 2020 •
edited
Loading

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-25 03:13:22 UTC

@williamFalcon williamFalcon added the ready PRs ready to be merged label Jun 25, 2020
@williamFalcon williamFalcon merged commit f2710bb into master Jun 25, 2020
@Borda Borda deleted the hp branch June 25, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

Assignees
No one assigned
Labels
bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in TensorBoardLogger add_hparams() tensorboard hyperparameters don't update
3 participants
@williamFalcon @pep8speaks @Borda