Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored training_batch + tests to verify correctness #2328

Merged
merged 11 commits into from
Jun 23, 2020
Merged

refactored training_batch + tests to verify correctness #2328

merged 11 commits into from
Jun 23, 2020

Conversation

williamFalcon
Copy link
Contributor

Fixes #2320

Co-authored with #2327

@pep8speaks
Copy link

pep8speaks commented Jun 23, 2020 •
edited
Loading

Hello @williamFalcon! Thanks for updating this PR.

Line 680:13: E731 do not assign a lambda expression, use a def

Comment last updated at 2020-06-23 14:51:43 UTC

@mergify mergify bot requested a review from a team June 23, 2020 12:11
@williamFalcon williamFalcon changed the title refactored training_bath [WIP] refactored training_batch Jun 23, 2020
@williamFalcon williamFalcon changed the title [WIP] refactored training_batch refactored training_batch + tests to verify correctness Jun 23, 2020
@Borda Borda added the feature Is an improvement or enhancement label Jun 23, 2020
@williamFalcon williamFalcon merged commit 0f07381 into master Jun 23, 2020
@williamFalcon williamFalcon mentioned this pull request Jun 23, 2020
Closed
@Borda Borda deleted the closure branch June 23, 2020 15:22
@Borda Borda added this to the 0.8.x milestone Jun 23, 2020
@mmiakashs mmiakashs mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8.x
Development

Successfully merging this pull request may close these issues.

Partially missing training_step outputs in training_epoch_end
3 participants
@williamFalcon @pep8speaks @Borda