Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression metrics #2221

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Regression metrics #2221

merged 3 commits into from
Jun 17, 2020

Conversation

cuent
Copy link
Contributor

@cuent cuent commented Jun 17, 2020 •
edited by Borda
Loading

Before submitting

  • Was this discussed/approved via a Github issue?
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1304

Implements default torch functions by creating wrappers around Metric

@mergify mergify bot requested a review from a team June 17, 2020 13:43
@williamFalcon
Copy link
Contributor

@cuent can you add to the docs?

https://github.com/PyTorchLightning/pytorch-lightning/blob/master/docs/source/metrics.rst
https://pytorch-lightning.readthedocs.io/en/latest/metrics.html

@williamFalcon williamFalcon merged commit ead874b into Lightning-AI:master Jun 17, 2020
@williamFalcon
Copy link
Contributor

amazing @cuent !

@Borda Borda added the feature Is an improvement or enhancement label Jun 17, 2020
@Borda Borda added this to the 0.8.x milestone Jun 17, 2020
@williamFalcon williamFalcon mentioned this pull request Jun 17, 2020
Merged
@Borda Borda modified the milestones: 0.8.x, 0.8.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.8
Development

Successfully merging this pull request may close these issues.

Metrics: MSE, RMSE, MAE, RMSLE
3 participants
@cuent @williamFalcon @Borda