Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated API for v0.8 #2073

Merged
merged 14 commits into from
Jun 12, 2020
Merged

remove deprecated API for v0.8 #2073

merged 14 commits into from
Jun 12, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Jun 4, 2020

What does this PR do?

Fixes #780

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration let's do it! approved to implement Important labels Jun 4, 2020
@Borda Borda added this to the 0.8.0 milestone Jun 4, 2020
@mergify mergify bot requested a review from a team June 4, 2020 13:47
@Borda Borda force-pushed the deprecated/clean-v0.8 branch 2 times, most recently from fdb7568 to 2eb9c00 Compare June 5, 2020 12:06
@Borda Borda marked this pull request as ready for review June 5, 2020 17:41
@pep8speaks
Copy link

pep8speaks commented Jun 5, 2020

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-11 18:08:55 UTC

@mergify mergify bot requested a review from a team June 7, 2020 02:00
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #2073 into master will decrease coverage by 0%.
The diff coverage is 75%.

@@          Coverage Diff           @@
##           master   #2073   +/-   ##
======================================
- Coverage      86%     86%   -0%     
======================================
  Files          78      65   -13     
  Lines        4917    4858   -59     
======================================
- Hits         4229    4174   -55     
+ Misses        688     684    -4     

@Borda Borda added the ready PRs ready to be merged label Jun 7, 2020
@mergify mergify bot requested a review from a team June 7, 2020 10:38
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2020

This pull request is now in conflict... :(

@Borda
Copy link
Member Author

Borda commented Jun 11, 2020

@PyTorchLightning/core-contributors mind review this, it is mandatory for v0.8.0 🐰

@mergify mergify bot requested a review from a team June 11, 2020 17:55
@mergify mergify bot requested a review from a team June 11, 2020 17:56
@Borda Borda requested a review from williamFalcon June 11, 2020 18:08
@mergify mergify bot requested a review from a team June 11, 2020 20:53
@Borda Borda requested review from SkafteNicki and tullie June 11, 2020 20:59
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been looking forward to this, really cleans up the project a bit :)

@mergify mergify bot requested a review from a team June 12, 2020 10:54
@williamFalcon williamFalcon merged commit 2674976 into master Jun 12, 2020
@Borda Borda deleted the deprecated/clean-v0.8 branch June 12, 2020 19:17
Borda added a commit that referenced this pull request Jun 13, 2020
* remove deprecated API

* chlog

* times

* missed

* formatting check

* missing

* missing

* miss

* fix docs build error

* fix pep whitespace error

* docs

* wip

* amp_level

* amp_level

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
(cherry picked from commit 2674976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration let's do it! approved to implement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove deprecated APIs [TBD for v0.8.0]
5 participants