LearningRateLogger in multi-scheduler setting #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannz
force-pushed
the
lr-callback-pr
branch
2 times, most recently
from
2ec5688
to
2c57d5d
Compare
ivannz
changed the title
Borda
reviewed
May 25, 2020
tests/callbacks/test_callbacks.py
Outdated
| @@ -308,6 +310,24 @@ def test_lr_logger_single_lr(tmpdir): | |||
| 'Names of learning rates not set correctly' | |||
|
|
|||
|
|
|||
| def test_lr_logger_no_lr(tmpdir): | |||
There was a problem hiding this comment.
mind move all LR related test move to tests/callbacks/test_lr.py
SkafteNicki
approved these changes
May 25, 2020
Borda
approved these changes
May 25, 2020
|
This pull request is now in conflict... :( |
|
I rebased atop the current master. |
justusschock
approved these changes
May 26, 2020
justusschock
pushed a commit
that referenced
this pull request
Jun 29, 2020
* fixed undesired behaviour due to dict.fromkeys * a test for log length consistency * runtime-warn if no schedulers are configured * chlog * move Co-authored-by: Jirka <jirka@pytorchlightning.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues outlined in pr #1498:
MisconfigurationException, if no schedulers have been configured