Fix logger bug and prepare data bug #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1933 +/- ##
======================================
Coverage 88% 88%
======================================
Files 74 74
Lines 4603 4608 +5
======================================
+ Hits 4062 4068 +6
+ Misses 541 540 -1 |
Borda
reviewed
May 25, 2020
| @@ -128,3 +128,26 @@ def test_error_on_dataloader_passed_to_fit(tmpdir): | |||
|
|
|||
| with pytest.raises(MisconfigurationException): | |||
| trainer.fit(model, **fit_options) | |||
|
|
|||
|
|
|||
| def test_logger_reset_correctly(tmpdir): | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1898 and #1919
Fix problems with the logger not being reset correctly for the model after tuner algorithms and problems related to
prepare_databeing call too many times.Added some tests
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭