extend arg parser #1842
Merged
extend arg parser #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒 Comment last updated at 2020-05-14 20:06:36 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
======================================
Coverage 88% 88%
======================================
Files 71 71
Lines 4474 4485 +11
======================================
+ Hits 3929 3946 +17
+ Misses 545 539 -6 |
SkafteNicki
reviewed
May 14, 2020
pytorch_lightning/trainer/trainer.py
Outdated
| def parse_argparse(cli_parser: ArgumentParser) -> Namespace: | ||
| """Parse CLI arguments, required for custom bool types.""" | ||
| args = vars(cli_parser.parse_args()) | ||
| args = {k: True if v is None else v for k, v in args.items()} |
There was a problem hiding this comment.
what about including this in the from_argparse_args method, since most user setup already is:
parser = argparse.ArgumentParser(...)
parser = pl.Trainer.add_argparse_args(parser)
args = parser.parser_args()
trainer = pl.Trainer.from_argparse_args(args)
There was a problem hiding this comment.
done, pls check it now, plus added your code as example
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1829
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 馃檭