Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in semantic segmentation example #1824

Merged
merged 2 commits into from
May 14, 2020
Merged

fix bugs in semantic segmentation example #1824

merged 2 commits into from
May 14, 2020

Conversation

nanddalal
Copy link
Contributor

@nanddalal nanddalal commented May 13, 2020

What does this PR do?

This PR fixes a couple of bugs in the semantic segmentation example so that it starts running again:

  • typo in the unet example
  • aggregating the validation loss in the case of multiple gpus

Fixes #1697

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃yea! excited to start using pytorch-lightning

@mergify mergify bot requested a review from a team May 13, 2020 23:58
@nanddalal nanddalal changed the title fix typo in unet example fix bugs in semantic segmentation example May 14, 2020
@williamFalcon williamFalcon merged commit cf2d32d into Lightning-AI:master May 14, 2020
@nanddalal nanddalal deleted the patch-1 branch May 14, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Examples] The UNet model has some bugs
2 participants