Change lightning module params to dict when loading

[cmpute]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?
• If you made a notable change (that affects users), did you update the CHANGELOG?

This is a relatively small issue so I directly create a PR without issue.

What does this PR do?

When the checkpoint file is loaded, if lightning module has hparams as an argument for __init__, the hparams in checkpoint file will be fed. However it's fed as a positional argument, which means if hparams is not the first parameter for __init__, it will be loaded in an incorrect way. So this PR changes positional argument to a key-value pair based.

[pep8speaks]

Hello @cmpute! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-29 16:36:06 UTC

[Borda]

LGTM 🦝

[tullie]

The tests need to be fixed.

[cmpute]

It seems that a lot of the test are not running on the latest commit, how can I request the CI again?

[Borda]

It seems that a lot of the test are not running on the latest commit, how can I request the CI again?

I have restarted it but it is still failing, see

FAILED tests/models/test_restore.py::test_load_model_with_missing_hparams - T...
====== 1 failed, 243 passed, 27 skipped, 239 warnings in 82.34s (0:01:22) ======

[awaelchli]

Look at the error message:

  # load the state_dict on the model automatically
        kwargs.update(hparams=hparams)
>       model = cls(*args, **kwargs)
E       TypeError: __init__() got an unexpected keyword argument 'hparams'

It's running an old code, that's weird.
Maybe try force push again ?

[cmpute]

        # load the state_dict on the model automatically
        kwargs.update(hparams=hparams)
>       model = cls(*args, **kwargs)
E       TypeError: __init__() got an unexpected keyword argument 'hparams'

pytorch_lightning/core/lightning.py:1552: TypeError

In the CI test, this is the error reported, however in my branch, the code is actually

if hparams:
    kwargs.update(hparams=hparams)            
model = cls(*args, **kwargs)
model.load_state_dict(checkpoint['state_dict'])

Do I have to commit something to make this change take effect? :0

[cmpute]

I added another commit

[awaelchli]

seems to work now :) just the formatting now