Fixes CPU DDP breaking change and DDP change #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
======================================
Coverage 89% 89%
======================================
Files 71 71
Lines 4164 4169 +5
======================================
+ Hits 3689 3694 +5
Misses 475 475 |
Borda
reviewed
Apr 27, 2020
| @@ -637,6 +628,18 @@ def arg_default(x): | |||
|
|
|||
| return parser | |||
|
|
|||
| def allowed_type(x): | |||
There was a problem hiding this comment.
the two functions are are identical
Borda
pushed a commit
that referenced
this pull request
Apr 27, 2020
ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle ddp pickle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.