Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelCheckpoint not being picklable. #1632

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

quinor
Copy link
Contributor

@quinor quinor commented Apr 27, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1628 (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from a team April 27, 2020 09:32
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1632 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1632   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files          71      71           
  Lines        4164    4165    +1     
======================================
+ Hits         3689    3690    +1     
  Misses        475     475           

@williamFalcon williamFalcon merged commit 26933a9 into Lightning-AI:master Apr 27, 2020
@Borda Borda added the bug Something isn't working label Apr 27, 2020
@Borda Borda added this to the 0.7.5 milestone Apr 27, 2020
Borda pushed a commit that referenced this pull request Apr 27, 2020
@Borda Borda modified the milestones: 0.7.6, 0.7.5 Apr 27, 2020
@Borda Borda modified the milestones: 0.7.5, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in DDP, but not DP modes.
3 participants