Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix boolean argparse #1571

Merged
merged 2 commits into from
Apr 23, 2020
Merged

fix boolean argparse #1571

merged 2 commits into from
Apr 23, 2020

Conversation

fschlatt
Copy link
Contributor

@fschlatt fschlatt commented Apr 23, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • [] Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1570 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 23, 2020 12:57
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #1571 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1571   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files          68      68           
  Lines        3906    3906           
======================================
+ Hits         3471    3473    +2     
+ Misses        435     433    -2     

@Borda Borda changed the title fix boolean argparse #1570 fix boolean argparse Apr 23, 2020
@williamFalcon williamFalcon merged commit 545b38e into Lightning-AI:master Apr 23, 2020
@williamFalcon
Copy link
Contributor

@fschlatt awesome PR!
There's another issue where --gpus 1 or --gpus 8 does not work with this argparse method. want to look into that as well?

@Borda Borda added the bug Something isn't working label Apr 23, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 23, 2020
@fschlatt
Copy link
Contributor Author

@williamFalcon @Borda I'd love fix the --gpus bug but unfortunately I'm not able to run the tests. I'm trying to execute them from WSL with the bash script. But I get the error No module named py from the line python -m coverage run --source pytorch_lightning -m py.test pytorch_lightning tests pl_examples -v --doctest-modules --flake8.

@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer.add_argparse_args bool type
3 participants