attempting to remove some speed issues #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
======================================
- Coverage 91% 91% -0%
======================================
Files 67 67
Lines 3745 3742 -3
======================================
- Hits 3403 3400 -3
Misses 342 342 |
justusschock
approved these changes
Apr 14, 2020
benchmarks/test_trainer_parity.py
Outdated
| assert_speed_parity(pl_times, pl_times, num_epochs) | ||
|
|
||
|
|
||
| def assert_speed_parity(pl_times, pt_times, num_epochs): |
There was a problem hiding this comment.
do we really need this two times? Can't we just import the other one?
There was a problem hiding this comment.
fair, i was just trying to find the threshold number before finalizing pr. will refactor this
| @@ -112,10 +112,6 @@ def process_output(self, output, train=False): | |||
| num_gpus = self.num_gpus | |||
| callback_metrics = self.reduce_distributed_output(callback_metrics, num_gpus) | |||
|
|
|||
| for k, v in callback_metrics.items(): | |||
There was a problem hiding this comment.
it’s done twice. this is the first time but it’s done again at the end of the method
Borda
requested changes
Apr 14, 2020
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com>
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* removed some .items * added speed tests * added speed tests * Update benchmarks/test_rnn_parity.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * Update benchmarks/test_trainer_parity.py Co-Authored-By: Jirka Borovec <Borda@users.noreply.github.com> * fix lost model reference * added speed tests Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to match exact PT speed